From 068b4fb60e064f78e0da79e39fd002c2dc8450b6 Mon Sep 17 00:00:00 2001 From: Frank Brehm Date: Thu, 1 Feb 2024 10:36:56 +0100 Subject: [PATCH] Reworking usage of QUIET --- bin/manual-backup | 2 +- bin/update-minecraft-server-jar | 2 +- lib/functions.rc | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/bin/manual-backup b/bin/manual-backup index 5fa3e0b..db45507 100755 --- a/bin/manual-backup +++ b/bin/manual-backup @@ -602,7 +602,7 @@ sync_to_remote() { cmd+=" --verbose" fi cmd+=" \"${BACKUP_HOSTDIR}\" \"${rhost}:${BACKUP_PARENTDIR}\"" - if [[ "${QUIET}" == "y" ]] ; then + if [[ "${QUIET}" ]] ; then cmd+=" >> \"${LOGFILE}\" 2>&1" else cmd+=" 2>&1 | tee -a \"${LOGFILE}\"" diff --git a/bin/update-minecraft-server-jar b/bin/update-minecraft-server-jar index 7a8f006..bea0fdb 100755 --- a/bin/update-minecraft-server-jar +++ b/bin/update-minecraft-server-jar @@ -371,7 +371,7 @@ restart_service() { empty_line info "Status of '${CYAN}${service}${NORMAL}':" svc_status=$( systemctl status "${service}" 2>&1 ) - if [[ "${QUIET}" != "y" ]] ; then + if [[ -z "${QUIET}" ]] ; then echo "${svc_status}" fi MAIL_BODY+="\n$( my_date ): Status of service '${service}':\n${svc_status}\n" diff --git a/lib/functions.rc b/lib/functions.rc index 879f839..7ac1efe 100644 --- a/lib/functions.rc +++ b/lib/functions.rc @@ -32,7 +32,7 @@ VERBOSE="" DEBUG="" DO_ASK="" SIMULATE="" -QUIET="n" +QUIET="" LOGFILE= @@ -184,7 +184,7 @@ eval_common_options() { done fi - if [[ "${VERBOSE}" && "${QUIET}" == "y" ]] ; then + if [[ "${VERBOSE}" && "${QUIET}" ]] ; then error "The options '${RED}--verbose${NORMAL}' and '${RED}--quiet${NORMAL}' are mutually exclusive." echo usage >&2 @@ -299,7 +299,7 @@ info() { if [[ -n "${LOGFILE}" ]] ; then echo -e "[${ts}] [${BASE_NAME}:${GREEN}INFO${NORMAL}] : $@" >>"${LOGFILE}" fi - if [[ "${QUIET}" != "y" ]] ; then + if [[ -z "${QUIET}" ]] ; then echo -e " ${GREEN}*${NORMAL} [${ts}] [${BASE_NAME}:${GREEN}INFO${NORMAL}] : $@" >&2 fi } @@ -347,7 +347,7 @@ line() { echo "${l}" >>"${LOGFILE}" fi - if [[ "${QUIET}" == "y" ]] ; then + if [[ "${QUIET}" ]] ; then return fi echo "${l}" @@ -366,7 +366,7 @@ empty_line() { echo >>"${LOGFILE}" fi - if [[ "${QUIET}" == "y" ]] ; then + if [[ "${QUIET}" ]] ; then return fi echo -- 2.39.5