Applying shellcheck to scripts/get-rhel-dvd-iso-image

diff --git a/scripts/get-rhel-dvd-iso-image b/scripts/get-rhel-dvd-iso-image
index 9111e9f4a1a4339f08f342c397a1b5c9f56dff4c..172b9fe900665495aa3a6e4e4b7ba5b4f7312bfc 100755 (executable)
--- a/scripts/get-rhel-dvd-iso-image
+++ b/scripts/get-rhel-dvd-iso-image
@@ -3,14 +3,17 @@
 set -e
 set -u
 
-BASE_NAME="$( basename ${0} )"
-MY_REAL_NAME=$( readlink -f $0 )
+BASE_NAME="$( basename "${0}" )"
+MY_REAL_NAME=$( readlink -f "$0" )
 BIN_DIR=$( dirname "${MY_REAL_NAME}" )
 BASE_DIR=$( dirname "${BIN_DIR}" )
+# shellcheck disable=SC2034
 LIB_DIR="${BASE_DIR}/lib"
+# shellcheck disable=SC2034
 CONF_DIR="${BASE_DIR}/etc"
 
 if [[ -f "${BIN_DIR}/functions.rc" ]] ; then
+    # shellcheck disable=SC1091
     . "${BIN_DIR}/functions.rc"
 else
     echo "Bash resource file '${BIN_DIR}/functions.rc' not found" >&2
@@ -67,6 +70,7 @@ DOWNLOAD_URL=
 
 detect_color
 
+# shellcheck disable=SC2034
 DESCRIPTION=$( cat <<-EOF
        Download a Red Hat Enterprise Linux Binary DVD.
 
@@ -109,13 +113,13 @@ usage() {
 get_options() {
 
     local tmp=
-    local base_dir=
     local arg=
 
     set +e
-    tmp=$( getopt -o ${STD_SHORT_OPTIONS}O: \
-                  --long ${STD_LONG_OPTIONS},output: \
+    tmp=$( getopt -o "${STD_SHORT_OPTIONS}O:" \
+                  --long "${STD_LONG_OPTIONS},output:" \
                   -n "${BASE_NAME}" -- "$@" )
+    # shellcheck disable=SC2181
     if [[ $? != 0 ]] ; then
         echo "" >&2
         usage >&2
@@ -134,16 +138,15 @@ get_options() {
     local len="${#REMAINING_OPTS[*]}"
     local i="0"
     local j=
-    local output=
     while [[ "$i" -lt "${len}" ]] ; do
 
         arg="${REMAINING_OPTS[$i]}"
 
         case "${arg}" in
             -O|--output)
-                j=$(( $i + 1 ))
+                j=$(( i + 1 ))
                 OUTPUT="${REMAINING_OPTS[$j]}"
-                i=$(( $i + 2 ))
+                i=$(( i + 2 ))
                 ;;
             *)  echo -e "Internal error - option '${RED}${arg}${NORMAL}' was wrong!"
                 exit 1
@@ -208,6 +211,7 @@ get_access_token() {
         ACCESS_TOKEN="fake_access_token"
     else
         debug "Executing: ${cmd}"
+        # shellcheck disable=SC2086
         ACCESS_TOKEN=$( eval ${cmd} )
     fi
 
@@ -219,18 +223,20 @@ get_access_token() {
 get_image_info() {
 
     local output_base="${IMAGE_KEY}.iso"
-    local image_download_url=$( echo "${IMAGE_DOWNLOAD_URL}" | sed -e "s/@CHECKSUM@/${IMAGE_CHECKSUM}/" )
+    local image_download_url=
+    image_download_url="${IMAGE_DOWNLOAD_URL//@CHECKSUM@/${IMAGE_CHECKSUM}}"
     debug "Image download URL: '${CYAN}${image_download_url}${NORMAL}'."
 
     local cmd="curl --silent -H 'Authorization: Bearer ${ACCESS_TOKEN}' '${image_download_url}'"
 
     if [[ "${SIMULATE}" == "y" ]] ; then
         info "Executing: ${cmd}"
-        IMAGE="fake_image_info"
+        IMAGE_INFO="fake_image_info"
         BASE_FILE_NAME="fake-${output_base}"
         DOWNLOAD_URL="${image_download_url}"
     else
         debug "Executing: ${cmd}"
+        # shellcheck disable=SC2086
         IMAGE_INFO=$( eval ${cmd} )
         BASE_FILE_NAME=$( echo "${IMAGE_INFO}" | jq -r .body.filename)
         DOWNLOAD_URL=$( echo "${IMAGE_INFO}" | jq -r .body.href)
@@ -270,6 +276,7 @@ download_image() {
         info "Executing: ${cmd}"
     else
         debug "Executing: ${cmd}"
+        # shellcheck disable=SC2086
         eval ${cmd}
     fi
 }